Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: added start:with-theme script #378

Conversation

PKulkoRaccoonGang
Copy link
Contributor

Description

Added application start script with the ability to install the required theme (default @openedx/brand-openedx@latest). After interrupting a running process, the topic is automatically removed from the node_modules directory.

Related to: openedx/paragon#2831

@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc3c958) 89.09% compared to head (ea74f2d) 89.09%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files           6        6           
  Lines          55       55           
  Branches       18       18           
=======================================
  Hits           49       49           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov
Copy link

viktorrusakov commented Dec 15, 2023

@PKulkoRaccoonGang This is not an MFE, it's just a package that exports some components, I don't think npm start even works here, so we don't need to add this script.

edit: I didn't see there is an example MFE in the repo, then it makes sense to add this script

@viktorrusakov viktorrusakov merged commit 59c78ac into openedx:master Dec 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants